Skip to content

build: Install libFoundationNetworking.so as part of the build #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented May 27, 2019

  • libFoundationNetworking was not being installed into the final output
    directory and was missing from the tarfile.

@spevans
Copy link
Contributor Author

spevans commented May 27, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented May 27, 2019

cc @millenomi @compnerd

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the windows platform at parity when making changes.

@spevans
Copy link
Contributor Author

spevans commented May 27, 2019

@swift-ci test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to squash the changes

- libFoundationNetworking was not being installed into the final output
  directory and was missing from the tarfile.
@spevans spevans force-pushed the pr_install_foundation_networking branch from 51b06c5 to 4f1cb46 Compare May 28, 2019 04:43
@spevans
Copy link
Contributor Author

spevans commented May 28, 2019

@swift-ci test and merge

2 similar comments
@spevans
Copy link
Contributor Author

spevans commented May 28, 2019

@swift-ci test and merge

@spevans
Copy link
Contributor Author

spevans commented May 28, 2019

@swift-ci test and merge

@swift-ci swift-ci merged commit 3bf64a9 into swiftlang:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants